Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: turn on assertion checks #21499

Merged
merged 1 commit into from
Oct 6, 2024
Merged

CI: turn on assertion checks #21499

merged 1 commit into from
Oct 6, 2024

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Oct 4, 2024

This turn on assertions from qbt codebase so that testers can verify the assertions really hold.

This turn on assertions from qbt codebase so that testers can verify the assertions really hold.
@Chocobo1 Chocobo1 added the CI Issues/PRs related to CI label Oct 4, 2024
@Chocobo1 Chocobo1 requested a review from a team October 4, 2024 15:14
@glassez
Copy link
Member

glassez commented Oct 4, 2024

This turn on assertions from qbt codebase

Are they turned off? Or do we produce release builds on CI for some reason?

@Chocobo1
Copy link
Member Author

Chocobo1 commented Oct 4, 2024

Are they turned off?

Yes, due to QT_NO_DEBUG defined via Qt library.
Qt cmake script will define it by default for every mode except debug mode. Even none/empty mode has it defined.

Or do we produce release builds on CI for some reason?

I would like the CI artifacts to still be fast enough. Full debug mode might be too inefficient.

@glassez
Copy link
Member

glassez commented Oct 4, 2024

Strange... If I'm not mistaken, we've seen assertions triggered even in official builds.

@Chocobo1
Copy link
Member Author

Chocobo1 commented Oct 4, 2024

Strange... If I'm not mistaken, we've seen assertions triggered even in official builds.

I don't know, maybe the official builds used different set of compile flags.

@Chocobo1 Chocobo1 merged commit 6ed662c into qbittorrent:master Oct 6, 2024
14 checks passed
@Chocobo1 Chocobo1 deleted the assert branch October 6, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues/PRs related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants