Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http proxy server: don't work as an actual proxy #49

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

jstucke
Copy link
Contributor

@jstucke jstucke commented Jan 19, 2024

As #43 pointed out, it is not a good idea for a honeypot to work as an actual proxy server, because this can be misused in a malicious way.

This PR tries to solve this by returning a dummy website instead of the actual website and was based on #44.

  • adds a dummy website and adds it to the installation
  • returns the dummy website instead of the actual website in http_proxy_server.py
  • adds a wait time to fix problems with a flaky test

resolves #43

@AndreC10002
Copy link

Thank you for reviewing this item.
Could we have the dummy website read from a local file? And it would be great to make the file path configurable.
Sorry I don't know enough of this project's code to implement that.

@giga-a giga-a merged commit 45b1f6b into qeeqbox:main Jan 19, 2024
@jstucke
Copy link
Contributor Author

jstucke commented Jan 22, 2024

Could we have the dummy website read from a local file? And it would be great to make the file path configurable.

Yes that shouldn't be much of a problem. I will look into it

@jstucke
Copy link
Contributor Author

jstucke commented Jan 29, 2024

Thank you for reviewing this item. Could we have the dummy website read from a local file? And it would be great to make the file path configurable. Sorry I don't know enough of this project's code to implement that.

It seems to work already on the fork but it will probably also get merged back here soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honeypots shouldn't do certain things, proxying is one of them
4 participants