Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove forced browser_version just to get tests running #165

Closed
wants to merge 9 commits into from
6 changes: 4 additions & 2 deletions .github/workflows/linux_acceptance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:
# arrays for matrices must be given as string for json parsing
# https://github.community/t/reusable-workflow-with-strategy-matrix/205676
os: '["ubuntu-latest"]'
browser: '["chrome", "firefox", "edge"]'
python-version: '["3.9", "3.12"]'
# browser: '["chrome", "firefox", "edge"]'
browser: '["chrome"]'
# python-version: '["3.9", "3.12"]'
python-version: '["3.11"]'
rfw-4x-python: "3.9"
6 changes: 4 additions & 2 deletions .github/workflows/mac_acceptance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ jobs:
# arrays for matrices must be given as string for json parsing
# https://github.community/t/reusable-workflow-with-strategy-matrix/205676
os: '["macos-latest"]'
browser: '["chrome", "edge", "safari"]'
python-version: '["3.10", "3.11"]'
# browser: '["chrome", "edge", "safari"]'
browser: '["edge"]'
# python-version: '["3.10", "3.11"]'
python-version: '["3.10"]'
rfw-4x-python: "3.10"
rfw-exclude-tags: "-e RESOLUTION_DEPENDENCY -e FLASK"
8 changes: 6 additions & 2 deletions .github/workflows/tests_reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@ jobs:
-e PROBLEM_IN_${{ runner.os }}
-e PROBLEM_IN_${{ matrix.browser }}
-v BROWSER:${{ matrix.browser }}
-v BROWSER_VERSION:127
-v browser_options:"--disable-gpu"
-s Frame
-L DEBUG
-d result
--name ${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.browser }}
-b debug.txt
Expand All @@ -201,7 +203,9 @@ jobs:
-e PROBLEM_IN_${{ runner.os }}
-e PROBLEM_IN_${{ matrix.browser }}
-v BROWSER:${{ matrix.browser }}
-v BROWSER_VERSION:127
-v browser_options:"--disable-gpu"
-s Frame
-L DEBUG
-d rerunresult
--name ${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.browser }}
-b debug.txt
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/win_acceptance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ jobs:
# arrays for matrices must be given as string for json parsing
# https://github.community/t/reusable-workflow-with-strategy-matrix/205676
os: '["windows-latest"]'
browser: '["chrome", "edge", "firefox"]'
python-version: '["3.11", "3.12"]'
# browser: '["chrome", "edge", "firefox"]'
browser: '["chrome"]'
#python-version: '["3.11", "3.12"]'
python-version: '["3.12"]'
rfw-4x-python: "3.11"
rfw-exclude-tags: "-e FLASK"

1 change: 1 addition & 0 deletions QWeb/internal/browser/edge.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ def open_browser(
options.browser_version = edge_version

if user.is_root() or user.is_docker():
logger.info(f"***** no-sandbox: ({user.is_root()}) {user.is_docker()}*****")
options.add_argument("no-sandbox") # pylint: disable=no-member
if edge_args:
if any("--headless" in _.lower() for _ in edge_args):
Expand Down
3 changes: 2 additions & 1 deletion QWeb/internal/frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from selenium.webdriver.remote.webelement import WebElement
from selenium.common.exceptions import (
NoSuchWindowException,
NoSuchFrameException,
StaleElementReferenceException,
UnexpectedAlertPresentException,
WebDriverException,
Expand Down Expand Up @@ -204,7 +205,7 @@ def search_from_frames(
try:
driver.switch_to.frame(current_frame)
logger.debug(f"Switching to child frame {str(fn)}")
except (StaleElementReferenceException, WebDriverException) as e:
except (StaleElementReferenceException, NoSuchFrameException, WebDriverException) as e:
logger.debug(str(e))
driver.switch_to.default_content()
raise e
Expand Down
3 changes: 2 additions & 1 deletion test/acceptance/parallel/frame.robot
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
*** Settings ***
Documentation Tests for frame keywords
Library QWeb
Suite Setup OpenBrowser ${BASE_URI}/frame.html ${BROWSER} --headless
Suite Setup OpenBrowser ${BASE_URI}/frame.html ${BROWSER} #--headless
Suite Teardown CloseBrowser
Test Timeout 60 seconds

Expand Down Expand Up @@ -33,6 +33,7 @@ Back & Forward
${url}= GetUrl
Should Be Equal ${url} about:blank
Back
RefreshPage

Use Frame And Use Page
[Tags] Frame
Expand Down