Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change elevation profile name #58532

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Conversation

Simon-Lopez
Copy link
Contributor

@Simon-Lopez Simon-Lopez commented Aug 29, 2024

Description

This PR is a simple proposal to answer #58455.
It adds a "Change Progile Name" menu item in the Options sub-menu of the Elevation Profile widget in order to allow the user to change the profile windows name to anything more meaningfull to him/her. The change is made through a modal QInputDialog.

image

image

Fixes #58455

@github-actions github-actions bot added this to the 3.40.0 milestone Aug 29, 2024
@DelazJ
Copy link
Contributor

DelazJ commented Aug 30, 2024

Great initiative @Simon-Lopez 👍🏿 . thanks.
There is a dedicated class for dialog renaming you might want to use here: QgsNewNameDialog.
Also, instead of "Change profile name", maybe "Rename profile" or "Rename view" are more inline with QGIS practices.
Questions: should this be the first or the last option in the drop down? In map view settings, it is at the end I think. I was also wondering if that dialog should also popup at the profile creation time, as done for layouts?

@Simon-Lopez
Copy link
Contributor Author

Thanks so much for the feedback @DelazJ. (I'm a newbie here...)
I'm making the changes you propose.
And, yes, it seems a good idea to follow the "map view settings" layout.

This adds a menu item in the Options sub-menu to change the windows name
to something meaningfull to the user.
@Simon-Lopez
Copy link
Contributor Author

I've applied your suggestions @DelazJ.

@nyalldawson
Copy link
Collaborator

Nice work @Simon-Lopez -- just needed some capitalization fixes to match QGIS HIG guidelines

Copy link

github-actions bot commented Sep 1, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 4b7d033)

@nyalldawson nyalldawson merged commit 9ea1ddb into qgis:master Sep 1, 2024
28 checks passed
@DelazJ
Copy link
Contributor

DelazJ commented Sep 2, 2024

Good job @Simon-Lopez 👍🏿

@DelazJ DelazJ added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 2, 2024
@qgis-bot
Copy link
Collaborator

qgis-bot commented Sep 2, 2024

@Simon-Lopez

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Sep 2, 2024

@Simon-Lopez
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Sep 2, 2024

@Simon-Lopez
A documentation ticket has been opened at qgis/QGIS-Documentation#9224
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use custom title for Elevation Profile window
5 participants