Fix building for Qt6 on windows #58563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. It's what's already used to build master for qt5+6 in osgeo4w (https://github.com/jef-n/OSGeo4W/blob/master/src/qgis-dev/osgeo4w/patch + https://github.com/jef-n/OSGeo4W/blob/master/src/qgis-qt6-dev/osgeo4w/patch). |
jef-n
approved these changes
Sep 3, 2024
|
Let's ignore the clang-tidy warnings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shameless plug from #57445
USE_CCACHEalso for windowsRefs #56980 #57414 #57002
Doesn't yet change anything wrt ci checks to be easy on our infrastructure, but will already now ease the pain to maintain patchsets outside.
CC @jef-n @MehdiChinoune