Mesh point add elevation #58877
Open
Mesh point add elevation #58877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
reviewed
Sep 26, 2024
uclaros
reviewed
Sep 27, 2024
uclaros
added
Frozen
uclaros
reviewed
Sep 27, 2024
JanCaha
commented
Oct 2, 2024
Comment on lines
+2793
to
+2807
| { | ||
| if ( mZValueWidget->getZFromProjectElevationEnabled() ) | ||
| { | ||
| const QgsAbstractTerrainProvider *terrainProvider = QgsProject::instance()->elevationProperties()->terrainProvider(); | ||
| const QgsCoordinateTransform transformation = QgsCoordinateTransform( mCurrentLayer->crs(), terrainProvider->crs(), QgsProject::instance() ); | ||
|
|
||
| try | ||
| { | ||
| const QgsPointXY point = transformation.transform( effectivePoint.x(), effectivePoint.y() ); | ||
| zValue = terrainProvider->heightAt( point.x(), point.y() ); | ||
| } | ||
| catch ( const QgsCsException & ) | ||
| { | ||
| zValue = std::numeric_limits<double>::quiet_NaN(); | ||
| } |
There was a problem hiding this comment.
@uclaros unlike what we discussed last week, this cannot be moved up in the hierarchy of those if else statements.
I believe that this settings should only affect newly added vertices that are isolated. We probably do not want to affect behavior when adding vertices on edges and in faces (those have Z interpolated from the MESH vertices itself) and that is what the previous if else statements do. We only what to affect the else branch which are the isolated vertices. So I believe that this should be correct.
|
@uclaros This should be ready, all the review comments are addressed. Only need to solve the comment above ;-) |
lbartoletti
added
the
Requires Tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR make some changes when adding new vertices to the MeshLayer.
ZValuesWidgetQgsAbstractTerrainProviderto currently selected verticesQgsAbstractTerrainProvider, when the point is createdThe placement of the new button and checkbox is up for discussion, so far it is added into
ZValuesWidgetfor convenience