Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW: distro updates & removing gneiss #561

Merged
merged 4 commits into from
Oct 10, 2023
Merged

NEW: distro updates & removing gneiss #561

merged 4 commits into from
Oct 10, 2023

Conversation

lizgehret
Copy link
Member

No description provided.

ebolyen
ebolyen requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ebolyen ebolyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tabs for each distro don't work because they all share the same id="" html attrs.

We should either make every ID and href=#id unique, or use classes and update the javascript to tab all distros at once. Either seems fine with me.

ebolyen
ebolyen approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ebolyen ebolyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ebolyen ebolyen merged commit 99d0845 into master Oct 10, 2023
2 checks passed
@lizgehret lizgehret deleted the distro-updates branch October 10, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebolyen ebolyen ebolyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizgehret @ebolyen @gregcaporaso