Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Updates to importing tutorial #567

Merged
merged 4 commits into from
Nov 8, 2023
Merged

MAINT: Updates to importing tutorial #567

merged 4 commits into from
Nov 8, 2023

Conversation

hagenjp
Copy link
Contributor

@hagenjp hagenjp commented Nov 3, 2023 •
edited by lizgehret
Loading

Closes: #713 and #558

@lizgehret
Copy link
Member

These changes look great, thanks @hagenjp! Going to pull this down and render locally, but this should be g2g.

@lizgehret lizgehret linked an issue Nov 7, 2023 that may be closed by this pull request
BUG: broken link in importing data tutorial #558
Closed
lizgehret
lizgehret requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@lizgehret lizgehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just rendered this locally and tested the updated import commands - looks like the --importable flag should be swapped (so that it's associated with list-formats instead of list-types). Once that suggestion has been implemented, this is all set to merge!

source/tutorials/importing.rst Outdated Show resolved Hide resolved
source/tutorials/importing.rst Outdated Show resolved Hide resolved
@lizgehret lizgehret merged commit 6f2aba2 into qiime2:master Nov 8, 2023
2 checks passed
@lizgehret lizgehret changed the title Updates to importing tutorial MAINT: Updates to importing tutorial Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizgehret lizgehret lizgehret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
2024.2
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

small edit needed in tutorial BUG: broken link in importing data tutorial
2 participants
@hagenjp @lizgehret