Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMP: add rarefy and rarefaction definition to glossary #571

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

cherman2
Copy link
Contributor

This PR adds rarefy and rarefaction definitions to the glossary. Ref: https://www.biorxiv.org/content/10.1101/2023.06.23.546312v1.full

@gregcaporaso gregcaporaso self-assigned this Dec 21, 2023
Copy link
Member

@gregcaporaso gregcaporaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cherman2, a few suggestions on this. If you're good with these, this is ready for merge. Let me know if you have any questions. Thanks for adding these!

source/glossary.rst Outdated Show resolved Hide resolved
source/glossary.rst Outdated Show resolved Hide resolved
source/glossary.rst Outdated Show resolved Hide resolved
source/glossary.rst Outdated Show resolved Hide resolved
cherman2 and others added 4 commits January 5, 2024 13:05
Co-authored-by: Greg Caporaso <[email protected]>
Co-authored-by: Greg Caporaso <[email protected]>
Co-authored-by: Greg Caporaso <[email protected]>
Co-authored-by: Greg Caporaso <[email protected]>
@cherman2
Copy link
Contributor Author

cherman2 commented Jan 5, 2024

Hi @gregcaporaso, Thanks for the review! Once this passes CI, I will merge!

@cherman2 cherman2 merged commit f4f5bc6 into qiime2:master Jan 5, 2024
2 checks passed
@cherman2 cherman2 deleted the rarefy-def branch January 5, 2024 21:00
@gregcaporaso
Copy link
Member

Thanks @cherman2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants