Fixes #149 #286
Open
Fixes #149 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasade
commented
Sep 20, 2023
Comment on lines
+34
to
+35
| if group is None: | ||
| continue |
There was a problem hiding this comment.
@gregcaporaso, we simply ignore tables where a null group was observed. The null is exposed via the .get in the partition_f. Does that seem reasonable for the intended uses?
There was a problem hiding this comment.
Just to make sure I understand: you generate the partitioned table containing all samples that are missing metadata (i.e., the value is null), but just don't do anything with it so it's not included in the output? If so, that seems fine to me.
There was a problem hiding this comment.
Correct. Specifically, if the sample ID is not in the metadata lookup, a None is returned. The None group is then ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149. Note merge items reflected in #149 were resolved in a different PR it seems. Added use of
partitionforsplit.