Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST: more robust testing for volatility plot #187

Merged
merged 6 commits into from
Sep 4, 2024
Merged

TEST: more robust testing for volatility plot #187

merged 6 commits into from
Sep 4, 2024

Conversation

Oddant1
Copy link
Member

@Oddant1 Oddant1 commented Jun 12, 2024

This test may be slightly insane.

@Oddant1 Oddant1 changed the title Starti fiddling Start fiddling Jun 12, 2024
@Oddant1 Oddant1 marked this pull request as draft June 12, 2024 17:54
@Oddant1
Copy link
Member Author

Oddant1 commented Jun 12, 2024

This test is probably not really gonna work out.

@Oddant1 Oddant1 changed the title Start fiddling Start fiddling with plot test Jun 13, 2024
@Oddant1
Copy link
Member Author

Oddant1 commented Jul 29, 2024

@ebolyen suggested maybe forcing the viz to render as an svg during testing so we can just assert that divs exist

@Oddant1 Oddant1 marked this pull request as ready for review August 27, 2024 19:54
@Oddant1 Oddant1 removed their assignment Aug 27, 2024
@Oddant1 Oddant1 requested a review from lizgehret August 27, 2024 20:21
lizgehret
lizgehret approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@lizgehret lizgehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice approach @Oddant1, this type of testing will really help us with the rest of our visualizations 🥳

@lizgehret lizgehret changed the title Start fiddling with plot test TEST: more robust testing for volatility plot Sep 4, 2024
@lizgehret lizgehret merged commit 207dda1 into qiime2:dev Sep 4, 2024
4 checks passed
@lizgehret lizgehret assigned Oddant1 and unassigned lizgehret Sep 4, 2024
@Oddant1 Oddant1 removed their assignment Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizgehret lizgehret lizgehret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
2024.10 🎃
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oddant1 @lizgehret