Merge pull request #34 from AY2324S2-CS2103T-T09-4/master

Update
qinxutan · Apr 15, 2024 · 78abdc0 · 78abdc0
2 parents d05fcf5 + e680930
commit 78abdc0
Show file tree

Hide file tree

Showing 9 changed files with 193 additions and 202 deletions.
diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md
diff --git a/docs/UserGuide.md b/docs/UserGuide.md
diff --git a/docs/diagrams/ArchitectureSequenceDiagram.puml b/docs/diagrams/ArchitectureSequenceDiagram.puml
@@ -8,10 +8,10 @@ Participant ":Logic" as logic LOGIC_COLOR
 Participant ":Model" as model MODEL_COLOR
 Participant ":Storage" as storage STORAGE_COLOR
 
-user -[USER_COLOR]> ui : "delete 1"
+user -[USER_COLOR]> ui : "/delete_student index/1"
 activate ui UI_COLOR
 
-ui -[UI_COLOR]> logic : execute("delete 1")
+ui -[UI_COLOR]> logic : execute("/delete_student index/1")
 activate logic LOGIC_COLOR
 
 logic -[LOGIC_COLOR]> model : deletePerson(p)

diff --git a/docs/diagrams/DeleteSequenceDiagram.puml b/docs/diagrams/DeleteSequenceDiagram.puml
@@ -1,69 +1,77 @@
 @startuml
 !include style.puml
 skinparam ArrowFontStyle plain
+!define input "/delete_student index/1"
+
 
 box Logic LOGIC_COLOR_T1
 participant ":LogicManager" as LogicManager LOGIC_COLOR
 participant ":AddressBookParser" as AddressBookParser LOGIC_COLOR
-participant ":DeleteCommandParser" as DeleteCommandParser LOGIC_COLOR
-participant "d:DeleteCommand" as DeleteCommand LOGIC_COLOR
+participant ":DeleteStudentCommandParser" as DeleteStudentCommandParser LOGIC_COLOR
+participant "d:DeleteByIndexStudentCommand" as DeleteStudentByIndexCommand LOGIC_COLOR
 participant "r:CommandResult" as CommandResult LOGIC_COLOR
 end box
 
 box Model MODEL_COLOR_T1
 participant "m:Model" as Model MODEL_COLOR
 end box
 
-[-> LogicManager : execute("delete 1")
+[-> LogicManager : execute(input)
 activate LogicManager
 
-LogicManager -> AddressBookParser : parseCommand("delete 1")
+LogicManager -> AddressBookParser : parseCommand(input)
 activate AddressBookParser
 
-create DeleteCommandParser
-AddressBookParser -> DeleteCommandParser
-activate DeleteCommandParser
+create DeleteStudentCommandParser
+AddressBookParser -> DeleteStudentCommandParser
+activate DeleteStudentCommandParser
 
-DeleteCommandParser --> AddressBookParser
-deactivate DeleteCommandParser
+DeleteStudentCommandParser --> AddressBookParser
+deactivate DeleteStudentCommandParser
 
-AddressBookParser -> DeleteCommandParser : parse("1")
-activate DeleteCommandParser
+AddressBookParser -> DeleteStudentCommandParser : parse("index/1")
+activate DeleteStudentCommandParser
 
-create DeleteCommand
-DeleteCommandParser -> DeleteCommand
-activate DeleteCommand
+create DeleteStudentByIndexCommand
+DeleteStudentCommandParser -> DeleteStudentByIndexCommand
+activate DeleteStudentByIndexCommand
 
-DeleteCommand --> DeleteCommandParser :
-deactivate DeleteCommand
+DeleteStudentByIndexCommand --> DeleteStudentCommandParser :
+deactivate DeleteStudentByIndexCommand
 
-DeleteCommandParser --> AddressBookParser : d
-deactivate DeleteCommandParser
+DeleteStudentCommandParser --> AddressBookParser : d
+deactivate DeleteStudentCommandParser
 'Hidden arrow to position the destroy marker below the end of the activation bar.
-DeleteCommandParser -[hidden]-> AddressBookParser
-destroy DeleteCommandParser
+DeleteStudentCommandParser -[hidden]-> AddressBookParser
+destroy DeleteStudentCommandParser
 
 AddressBookParser --> LogicManager : d
 deactivate AddressBookParser
 
-LogicManager -> DeleteCommand : execute(m)
-activate DeleteCommand
+LogicManager -> DeleteStudentByIndexCommand : execute(m)
+activate DeleteStudentByIndexCommand
+
+DeleteStudentByIndexCommand -> Model : searchPersonByPredicate()
+activate Model
+
+Model --> DeleteStudentByIndexCommand : p
+deactivate Model
 
-DeleteCommand -> Model : deletePerson(1)
+DeleteStudentByIndexCommand -> Model : deletePerson(p)
 activate Model
 
-Model --> DeleteCommand
+Model --> DeleteStudentByIndexCommand
 deactivate Model
 
 create CommandResult
-DeleteCommand -> CommandResult
+DeleteStudentByIndexCommand -> CommandResult
 activate CommandResult
 
-CommandResult --> DeleteCommand
+CommandResult --> DeleteStudentByIndexCommand
 deactivate CommandResult
 
-DeleteCommand --> LogicManager : r
-deactivate DeleteCommand
+DeleteStudentByIndexCommand --> LogicManager : r
+deactivate DeleteStudentByIndexCommand
 
 [<--LogicManager
 deactivate LogicManager

diff --git a/docs/images/cmdguidewin.png b/docs/images/cmdguidewin.png
diff --git a/docs/images/cmdguidewin2.png b/docs/images/cmdguidewin2.png
diff --git a/docs/images/cmdmacguide.png b/docs/images/cmdmacguide.png
diff --git a/docs/images/cmdmacguide2.jpg b/docs/images/cmdmacguide2.jpg
diff --git a/src/main/java/seedu/address/logic/commands/RandomTeamAllocationCommand.java b/src/main/java/seedu/address/logic/commands/RandomTeamAllocationCommand.java
@@ -26,7 +26,7 @@ public class RandomTeamAllocationCommand extends Command {
             + "Parameters: "
             + PREFIX_MODULECODE + "MODULE CODE "
             + PREFIX_TUTORIALCLASS + "TUTORIAL CLASS "
-            + PREFIX_NUM_OF_TEAMS + "NUMBER OF TEAMS "
+            + PREFIX_NUM_OF_TEAMS + "NUMBER OF TEAMS \n"
             + "Example: " + COMMAND_WORD + " "
             + PREFIX_MODULECODE + "CS2103T "
             + PREFIX_TUTORIALCLASS + "T09 "