feat: add the PySCFGroundStateSolver #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrossinek
force-pushed
the
pyscf-ground-state-solver
branch
from
b1e9665
to
36107fe
Compare
mrossinek
force-pushed
the
pyscf-ground-state-solver
branch
from
36107fe
to
82cd8a1
Compare
Pull Request Test Coverage Report for Build 5220560044
💛 - Coveralls |
|
Rerunning CI here to see if the fix from qiskit-community/qiskit-nature#1202 propagates down to fix things here, too 👍 |
woodsp-ibm
reviewed
Jun 8, 2023
|
Thanks for the review! Seems like I overlooked quite a lot of things. I guess I should go back to my development style of always writing |
woodsp-ibm
reviewed
Jun 8, 2023
This is currently not guaranteed to give the correct result. I know a way of fixing this when having the MO coefficients available but we do not have them here. Will investigate this in the future. For now, we simply do not compute the spin related values.
mrossinek
commented
Jun 9, 2023
woodsp-ibm
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
PySCFGroundStateSolver, a new class which flips the API integration on its head, by using PySCF'sfcimodule to allow solving Qiskit Nature problems.This obviously will not scale to huge problems but I find this to be a useful utility when testing and debugging classical computational workflows in Qiskit Nature. Especially since this approach is a lot more performant than the
NumPyMinimumEigensolveralternative with afilter_criterionadded into it (see also Qiskit/qiskit#10194).Details and comments