Bugfix/logback 1701 newrule is ignored #681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Antonio Alvarez <[email protected]>
Signed-off-by: Jose Antonio Alvarez <[email protected]>
jaam
force-pushed
the
bugfix/LOGBACK-1701-newrule-is-ignored
branch
from
dc9415d
to
36cda65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, we are upgrading our product to Spring Boot 3.1.0 (which uses logback 1.4.7) and then we noticed that configurations in logback-spring.xml were being ignored.
After some debugging I noticed the code is commented out (SimpleRuleStore.java#87) and after searching in JIRA, I saw it has been reported already (https://jira.qos.ch/browse/LOGBACK-1701) and closed. Our use case is simple, with the newRule we reference the AppenderRefAction in a custom Appender to be able to delegate to a second appender under certain conditions.
This pull request just takes out the commented code and provides a simple fix. If the PR is declined, is there an alternative to it? This would potentially block our ongoing migration until an alternative solution is found.
By the way, the documentation still refers to this configuration option: https://logback.qos.ch/manual/onJoran.html#newRule.
Best regards and thank you for your time,
José