Documentation in template files #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add directory resources to rebuild container on template changes
- add tests for path resolving
- doc improvement
add performance test
# Conflicts: # src/Component/ComponentItemFactory.php # tests/Functional/Service/ComponentItemFactoryTest.php
# Conflicts: # composer.json # src/Component/ComponentItemFactory.php # src/Controller/TwigDocController.php # src/DependencyInjection/Configuration.php # src/DependencyInjection/TwigDocExtension.php # src/Service/ComponentService.php # src/Twig/TwigDocExtension.php # tests/Functional/Service/ComponentItemFactoryTest.php # tests/Unit/Component/ComponentItemFactoryTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dieser PR ermöglicht es, die Komponenten-Konfiguration direkt in den templates anzugeben. Hierfür wird in den templates ein Twig-Comment Block verwendet.
Über einen konfigurierbaren identifier (default: TWIG_DOC) wird dann in einem Compiler-Pass die Konfiguration aus allen templates extrahiert, mit der Konfiguration aus der Bundle-Konfiguration gemerged und dem ComponentService als Konstruktor-Argument übergeben. Es werden nur templates beachtet die einen entsprechenden Block beinhalten.
Es ist nun auch möglich, die Verzeichnisse zu konfigurieren in denen nach Komponenten gesucht wird. Als default wird
%twig.default_path%/componentsverwendet. Zusätzlich können weitere Verzeichnisse angegeben werden. Der Compiler-Pass ignoriert alle Verzeichnisse die nicht existieren.Die Dokumentation wurde entsprechend angepasst.