forked from VOICEVOX/voicevox_core
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add: C APIの
#[repr(Rust)]
なものへのアクセスをすべて安全にする (VOICEVOX#849)
C APIにおいて、Rust APIのオブジェクトそのものの代わりにトークンのような 1-bit長の構造体ユーザーに渡すようにすることで、次のことを実現する。 1. "delete"時に対象オブジェクトに対するアクセスがあった場合、アクセスが 終わるまで待つ 2. 次のユーザー操作に対するセーフティネットを張り、パニックするようにす る 1. "delete"後に他の通常のメソッド関数の利用を試みる 2. "delete"後に"delete"を試みる 3. そもそもオブジェクトとして変なダングリングポインタが渡される ドキュメントとしてのsafety requirementsもあわせて緩和する。 Resolves VOICEVOX#836.
- Loading branch information
Showing
13 changed files
with
645 additions
and
244 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.