Call QQuickItemPrivate::transformChanged when the clip is dirtied

An item that observes the viewport may use this to do clipping via QQuickItem::clipRect(), in which case changing the clip of a parent item needs to be reflected by a transformChanged call for the observing item. Change-Id: I02df01a6ff6d48695bcf55a65983966c0575d86b Reviewed-by: Volker Hilsheimer <[email protected]>
qt · Dec 8, 2023 · cfb28a9 · cfb28a9
1 parent b00798d
commit cfb28a9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/quick/items/qquickitem.cpp b/src/quick/items/qquickitem.cpp
@@ -5377,7 +5377,7 @@ bool QQuickItemPrivate::transformChanged(QQuickItem *transformedItem)
     }
     // If ItemObservesViewport, clipRect() calculates the intersection with the viewport;
     // so each time the item moves in the viewport, its clipnode needs to be updated.
-    if (thisWantsIt && q->clip())
+    if (thisWantsIt && q->clip() && !(dirtyAttributes & QQuickItemPrivate::Clip))
         dirty(QQuickItemPrivate::Clip);
     return ret;
 }
@@ -6629,7 +6629,7 @@ void QQuickItemPrivate::dirty(DirtyType type)
             QQuickWindowPrivate::get(window)->dirtyItem(q);
         }
     }
-    if (type & (TransformOrigin | Transform | BasicTransform | Position | Size))
+    if (type & (TransformOrigin | Transform | BasicTransform | Position | Size | Clip))
         transformChanged(q);
 }