Add reset to QASM parser #6710
Open
Add reset to QASM parser #6710
+46
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rscircus
force-pushed
the
add-reset-gate
branch
from
f1f4288
to
be1a8a1
Compare
|
Rebased on top of main. |
rscircus
force-pushed
the
add-reset-gate
branch
2 times, most recently
from
44689b7
to
bfac925
Compare
rscircus
force-pushed
the
add-reset-gate
branch
2 times, most recently
from
a8cdb0b
to
dc4dffa
Compare
|
Squashing everything into one commit after we finish review. Thus I leave the generic 'Fix comments & typos' as it is for now. |
Add a test which can serve as example including the modifications to support the `reset` keyword in the import of QASM files in the PLY based lexer/parser.
rscircus
force-pushed
the
add-reset-gate
branch
from
1332b34
to
9d2be2d
Compare
|
Hey guys, you have any feedback on the solution proposal here? |
natestemen
approved these changes
Sep 27, 2024
| """reset : RESET qreg ';'""" | ||
| qreg = p[2] | ||
|
|
||
| p[0] = [ops.ResetChannel().on(qreg[i]) for i in range(len(qreg))] |
There was a problem hiding this comment.
Should there be some sort of check here to ensure the reset is applied on a qubit that is actually defined in the quantum register? E.g. should some error be raised when trying to parse the following QASM program?
OPENQASM 2.0;
include "qelib1.inc";
qreg q[1];
reset q[2];
|
It looks like there is an error in the parser:
Also, please run check/formatting in order to pass the format check. |
mhucka
added
status/stale
github-actions
bot
removed
the
status/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #6704
Note / 20240914:
After further inspection, I wonder why resets are implemented quite different to regular gates, despite following a somewhat similar terminology (
cirq.Rorcirq.reset) however, returning a ResetChannel. It appears to me that the reset is more similar to a measurement than compared to say a Hadamard gate.