Merge branch 'main' into 2024/07/31-gqsp-todo

quantumlib · Aug 1, 2024 · ec1b470 · ec1b470
2 parents c9e0695 + ca34060
commit ec1b470
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/qualtran/bloqs/bookkeeping/split_test.py b/qualtran/bloqs/bookkeeping/split_test.py
@@ -62,10 +62,8 @@ def test_classical_sim_dtypes():
     assert isinstance(xx, np.ndarray)
     assert xx.tolist() == [1, 1, 1, 1, 1, 1, 1, 1]
 
-    # TODO: Re-enable when Split/Join have real data types
-    #  https://github.com/quantumlib/Qualtran/issues/446
-    # with pytest.raises(ValueError):
-    #     _ = s.call_classically(reg=256)
+    with pytest.raises(ValueError):
+        _ = s.call_classically(reg=256)
 
     # with numpy types
     (xx,) = s.call_classically(reg=np.uint8(255))
@@ -77,7 +75,5 @@ def test_classical_sim_dtypes():
     assert isinstance(xx, np.ndarray)
     assert xx.tolist() == [0, 0, 0, 0, 0, 0, 0, 0]
 
-    # TODO: Re-enable when Split/Join have real data types
-    #  https://github.com/quantumlib/Qualtran/issues/446
-    # with pytest.raises(ValueError):
-    #     _ = s.call_classically(reg=np.uint16(256))
+    with pytest.raises(ValueError):
+        _ = s.call_classically(reg=np.uint16(256))