Restrict controlled from non-thru registers #1305
Open
+27
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Left a comment on the original issue - #1304 (comment) |
This was referenced Aug 21, 2024
|
Let's do this and relax later |
Comment on lines
-388
to
-397
| @attrs.frozen | ||
| class TestCtrlStatePrepAnd(Bloq): | ||
| """Decomposes into a Controlled-AND gate + int effects & targets where ctrl is active. | ||
|
|
||
| Tensor contraction should give the output state vector corresponding to applying an | ||
| `And(and_ctrl)`; assuming all the control bits are active. | ||
| """ | ||
|
|
||
| ctrl_spec: CtrlSpec | ||
| and_ctrl: Tuple[int, int] |
There was a problem hiding this comment.
Can we add a private flag to the Controlled class, something of the form _THRU_REGISTERS_ONLY = True, and keep this test around? Since we plan to relax this constraint later, it'll be nice to not delete the test.
Comment on lines
+315
to
+320
| @cached_property | ||
| def _thru_registers_only(self) -> bool: | ||
| for reg in self.subbloq.signature: | ||
| if reg.side != Side.THRU: | ||
| return False | ||
| return True |
There was a problem hiding this comment.
See other comment -- it'll be great if we can guard this with a flag set to TRUE by default. When we relax the condition, we can get rid of the flag and also keep the tests around.
tanujkhattar
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1304
Controlled