Remove _t_complexity_ #1377
Merged
Remove _t_complexity_ #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
commented
Sep 3, 2024
Comment on lines
291
to
310
| if self.legacy_shims: | ||
| legacy_val = bloq._t_complexity_() | ||
| if legacy_val is not NotImplemented: | ||
| warnings.warn( | ||
| "Please migrate explicit cost annotations to the general " | ||
| "`Bloq.my_static_costs` method override.", | ||
| DeprecationWarning, | ||
| ) | ||
| return GateCounts( | ||
| t=legacy_val.t, clifford=legacy_val.clifford, rotation=legacy_val.rotations | ||
| ) | ||
|
|
There was a problem hiding this comment.
Please see that all tests pass without this shim; but I think I'll put this back in (using getattr(bloq, '_t_complexity_', None) for a bit of backwards compatibility support
There was a problem hiding this comment.
Latest commit puts this back in
mpharrigan
force-pushed
the
2024-09/t-del
branch
from
05b759e
to
7cd87f0
Compare
|
End of an era! ptal @tanujkhattar |
tanujkhattar
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final part of #1251
This PR removes the legacy
_t_complexity_override from all bloqs. These were already redundant: during development of previous PRs I had removed use of these anyways. Those PRs did careful accounting of allbloq_exampleand unit test t complexity values and made sure they matched theQECGatesCostvalues (with some small, contained legacy shims). This PR shows that off!See my inline comments, but I left in a
getattrs-based shim so that the_t_complexity_override will still be used ifQECGatesCost()is in legacy mode. The only thing left in qualtran that uses it is a specific unit test I added to test it.