Update THC Prepare to use QROAMClean #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
summoning @tanujkhattar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use QROAMClean for THC prepare. Hit some issues with resource estimation notebook and fixes a bug with LCUBlockEncoding junk registers which may be sided (at least I think this is the desired behaviour).
BlackBoxPrepare does not work with sided registers either so I removed this from the resource estimation notebook (xref #1381)
I updated the call graph slightly to remove CirqGateAsBloq references and makes sure the decomposition matches the call graph.
I removed the PrepareTHC circuit diagram as the new QROAMClean bloq results in way too many junk registers making it unsightly (or really it just fails by default: #1380)