Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Equals() bloq #1411

Merged
merged 8 commits into from
Sep 24, 2024
Merged

Add Equals() bloq #1411

merged 8 commits into from
Sep 24, 2024

Conversation

fpapa250
Copy link
Contributor

Adds bloq to check if two quantum registers are equal.

NoureldinYosri
NoureldinYosri requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@NoureldinYosri NoureldinYosri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't use QAny instead take a dtype as input

qualtran/bloqs/arithmetic/comparison.py Outdated Show resolved Hide resolved
qualtran/bloqs/arithmetic/comparison.py Outdated Show resolved Hide resolved
qualtran/bloqs/arithmetic/comparison_test.py Outdated Show resolved Hide resolved
NoureldinYosri
NoureldinYosri requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@NoureldinYosri NoureldinYosri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

qualtran/bloqs/arithmetic/comparison.py Outdated Show resolved Hide resolved
qualtran/bloqs/arithmetic/comparison.py Show resolved Hide resolved
qualtran/bloqs/arithmetic/comparison.py Show resolved Hide resolved
@NoureldinYosri NoureldinYosri enabled auto-merge (squash) September 24, 2024 06:38
@NoureldinYosri NoureldinYosri merged commit a1df089 into quantumlib:main Sep 24, 2024
8 checks passed
@anurudhp anurudhp mentioned this pull request Sep 30, 2024
Merged
@fpapa250 fpapa250 mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anurudhp anurudhp anurudhp left review comments

@NoureldinYosri NoureldinYosri NoureldinYosri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fpapa250 @NoureldinYosri @anurudhp @mpharrigan