sparse state prep: allow user to pick target bitsize if needed #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tanujkhattar ptal |
qualtran/bloqs/state_preparation/sparse_state_preparation_via_rotations.py
Show resolved
Hide resolved
tanujkhattar
approved these changes
Oct 1, 2024
tanujkhattar
reviewed
Oct 1, 2024
| @@ -116,6 +116,7 @@ def assert_bloq_example_serializes_for_pytest(bloq_ex: BloqExample): | |||
| 'state_prep_via_rotation_symb', # cannot serialize HasLength | |||
| 'state_prep_via_rotation_symb_phasegrad', # cannot serialize Shaped | |||
| 'sparse_state_prep_via_rotations', # cannot serialize Permutation | |||
| 'sparse_state_prep_via_rotations_with_large_target_bitsize', # setting an array element with a sequence. | |||
There was a problem hiding this comment.
What's going on here? Is it because we can't serialize permutation?
tanujkhattar
reviewed
Oct 1, 2024
Comment on lines
+28
to
+33
| @pytest.mark.parametrize( | ||
| "bloq_ex", | ||
| [_sparse_state_prep_via_rotations, _sparse_state_prep_via_rotations_with_large_target_bitsize], | ||
| ) | ||
| def test_examples(bloq_autotester, bloq_ex): | ||
| bloq_autotester(bloq_ex) |
There was a problem hiding this comment.
Can we add a slow test that asserts the simulation is correct? The bloq example auto tests do not cover correctness of decomposition, AFAIR ?
There was a problem hiding this comment.
added simulation tests (at the end)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StatePreparationViaRotations