Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export static backend files for web app #1444

Merged
merged 9 commits into from
Oct 8, 2024
Merged

Export static backend files for web app #1444

merged 9 commits into from
Oct 8, 2024

Conversation

shab5
Copy link
Collaborator

@shab5 shab5 commented Oct 7, 2024

Export static backend files for the UI

@shab5 shab5 requested a review from mpharrigan October 7, 2024 17:20
@mpharrigan
Copy link
Collaborator

can you update the documenting-a-bloq directions in https://github.com/quantumlib/Qualtran/blob/main/qualtran/Autodoc.ipynb ?

And please provide a meaningful PR title. It'll be used as the commit title in the squash-and-merge.

Another process thing: can you please clear outputs from your notebook before committing to avoid churn in the git history

We'll have to be really careful merging this as the list of bloqdocspecs changes quite frequently. I understand you need to move it to the subdirector so it becomes importable, yes?

@shab5 shab5 changed the title U/shab5/UI export Export static backend files for web app Oct 7, 2024
@shab5
Copy link
Collaborator Author

shab5 commented Oct 7, 2024

can you update the documenting-a-bloq directions in https://github.com/quantumlib/Qualtran/blob/main/qualtran/Autodoc.ipynb ?

Done.

And please provide a meaningful PR title. It'll be used as the commit title in the squash-and-merge.

Done.

Another process thing: can you please clear outputs from your notebook before committing to avoid churn in the git history

Done.

We'll have to be really careful merging this as the list of bloqdocspecs changes quite frequently. I understand you need to move it to the subdirector so it becomes importable, yes?

Correct, I need to make it importable. I just pulled in the latest, so hopefully there won't be anything missing. Unfortunately, I rebased when I probably should have merged. Hopefully it's not too hard to review. Let me know if you need me to fix it.

dev_tools/conf/.pylintrc Outdated Show resolved Hide resolved
@mpharrigan
Copy link
Collaborator

I think there's some merge issues where changes that have been committed to main are getting pulled in here

@shab5
Copy link
Collaborator Author

shab5 commented Oct 7, 2024

I think there's some merge issues where changes that have been committed to main are getting pulled in here

Yep, sorry. Should be in better shape now.

@shab5 shab5 requested a review from mpharrigan October 7, 2024 23:16
@mpharrigan mpharrigan enabled auto-merge (squash) October 8, 2024 17:49
@mpharrigan mpharrigan enabled auto-merge (squash) October 8, 2024 17:49
@mpharrigan mpharrigan merged commit 4526507 into main Oct 8, 2024
11 checks passed
@shab5 shab5 deleted the u/shab5/ui-export branch October 8, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants