Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts need to be readable/executable as part of the root group in… #1317

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Jaland
Copy link

@Jaland Jaland commented Aug 17, 2023

… order to be used on an openshift container by default.

Check list:

Your pull request:

  • [x ] targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

Currently, if you try to use this docker file on Openshift you get a permissions error when trying to run run-java.sh. This is because the root group does not have access to execute that file. I don't think giving the root group access hurts the usage on other platforms but it will reduce the work for people trying to deploy onto Openshift.

… order to be used on an openshift container by default.
@gsmet
Copy link
Member

gsmet commented Aug 22, 2023

Thanks for this PR. I think we will have to also apply that to the project generation in the core repository.

@maxandersen do you know someone that would be able to be authoritative on these? I have seen some back and forth
regarding these permissions and it would be nice to have them settled once and for all with the current state of art in mind.

@maxandersen
Copy link
Member

Hmm. What version of openshift is it not working by default?

We already test and use this on multiple openshift versions so would want to know more before changing it (again) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants