Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Cells 🔬 #27

Merged
merged 6 commits into from
Jul 25, 2022
Merged

Create Cells 🔬 #27

merged 6 commits into from
Jul 25, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Jul 24, 2022

Cells 🔬

Initial cellular refactor, WIP. Progresses #26

  • Adds cells = states.map(createCell)
  • Adds type definitions for interface Cell
  • Updates state with cell.update(patch)
  • Updates Actions to fully stateless functions
  • Isolates components to focus scope of revisions:
    • State viewer
    • TransportControls
    • PlayPause
    • Clock
    • Menu
    • MidiPortSelect

Auto state redrawing temporarily handled by auto redrawing on all state changes:

cells.map(() => {
  m.redraw()
})

@mrharpo mrharpo added enhancement ➕ New feature or request breaking 💔 Breaking changes labels Jul 24, 2022
@mrharpo mrharpo added this to the v0.4.0 Cells 🔬 milestone Jul 24, 2022
@mrharpo mrharpo self-assigned this Jul 24, 2022
subcontrabass
subcontrabass approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@subcontrabass subcontrabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!! Cells ahoy

@mrharpo mrharpo merged commit 7df012c into v0.4.0 Jul 25, 2022
@mrharpo mrharpo deleted the cells branch July 25, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subcontrabass subcontrabass subcontrabass approved these changes

Assignees

@mrharpo mrharpo

Labels
breaking 💔 Breaking changes enhancement ➕ New feature or request
Projects
None yet
Milestone
v0.4.0 Cells 🔬
Development

Successfully merging this pull request may close these issues.
2 participants
@mrharpo @subcontrabass