Fix #4206: allow root folders named '/' #4207
Open
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drernie
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4207 +/- ##
========================================
Coverage 37.68% 37.69%
========================================
Files 768 768
Lines 35321 35326 +5
Branches 5021 5214 +193
========================================
+ Hits 13312 13317 +5
+ Misses 21402 20775 -627
- Partials 607 1234 +627
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
We have a customer with a lot of data in a path like "s3://bucket//raw". I presume the check was in place to prevent accidentally entering an absolute path. Should we drop it entirely, or provide a warning? |
sir-sigurd
changed the title
sir-sigurd
reviewed
Nov 6, 2024
nl0
reviewed
Nov 6, 2024
There was a problem hiding this comment.
looks reasonable in general. i defer to @sir-sigurd on this one
Co-authored-by: Sergey Fedoseev <[email protected]>
…iltdata/quilt into 4206-allow-root-folders-named
allow initial '/'
sir-sigurd
reviewed
Nov 8, 2024
sir-sigurd
reviewed
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
set_dir: Allow '/' folder in root.