Fix #4206: allow root folders named '/'

api/python/quilt3/data_transfer.py

@@ -876,7 +876,7 @@ def copy_file(src: PhysicalKey, dest: PhysicalKey, size=None, message=None, call
     """
     def sanity_check(rel_path):
         for part in rel_path.split('/'):
-            if part in ('', '.', '..'):
+            if part in ('.', '..'):
                 raise ValueError("Invalid relative path: %r" % rel_path)
 
     url_list = []

api/python/quilt3/util.py

@@ -139,8 +139,6 @@ def __init__(self, bucket, path, version_id):
             assert version_id is None, "Local keys cannot have a version ID"
             if os.name == 'nt':
                 assert '\\' not in path, "Paths must use / as a separator"
-        else:
-            assert not path.startswith('/'), "S3 paths must not start with '/'"
 
         self.bucket = bucket
         self.path = path
@@ -511,7 +509,7 @@ def validate_key(key):
         )
 
     for part in key.split('/'):
-        if part in ('', '.', '..'):
+        if part in ('.', '..'):
             raise QuiltException(
                 f"Invalid key {key!r}. "
                 f"A package entry key cannot contain a file or folder named '.' or '..' in its path."

api/python/tests/integration/test_packages.py

@@ -623,6 +623,8 @@ def test_s3_set_dir(self):
 
             list_object_versions_mock.assert_called_with('bucket', 'foo/')
 
+            pkg.set_dir('bar', 's3://bucket//foo')  # top-level '/' folder
+
     def test_set_dir_wrong_update_policy(self):
         """Verify non existing update policy raises value error."""
         pkg = Package()

docs/CHANGELOG.md

@@ -13,6 +13,12 @@ Entries inside each section should be ordered by type:
 ## CLI
 !-->
 
+# unreleased - YYYY-MM-DD
+
+## Python API
+
+* [Fixed] Allow S3 paths starting with `/` in `Package().set_dir()` ([#4207](https://github.com/quiltdata/quilt/pull/4207))
+
 # 6.1.0 - 2024-10-14
 
 ## Python API