-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select files and directories in a package to download #4173
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4173 +/- ##
==========================================
- Coverage 37.80% 37.69% -0.12%
==========================================
Files 766 768 +2
Lines 35195 35317 +122
Branches 5190 5022 -168
==========================================
+ Hits 13307 13313 +6
- Misses 21280 21396 +116
Partials 608 608
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…lt into selective-package-download
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable
Co-authored-by: Alexei Mochalov <[email protected]>
…lt into selective-package-download
Used Also, fixed route guarding: confirming navigation from package page when something is selected. The condition turned out to be quite sprawling: https://github.com/quiltdata/quilt/pull/4173/files#diff-95c902495a06ff31c5e3a2bede51af727048f9151bede5b5195a4f2cb8fc5090R106 |
Backend: https://github.com/quiltdata/enterprise/pull/779
Also, some refactoring and fixing minor bugs:
SelectionItem { logicalKey: string }
type instead of astring