Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select files and directories in a package to download #4173

Merged
merged 38 commits into from
Oct 17, 2024

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Oct 10, 2024

Backend: https://github.com/quiltdata/enterprise/pull/779

Screenshot from 2024-10-11 17-22-23
Screenshot from 2024-10-11 17-22-51

Also, some refactoring and fixing minor bugs:

  • SelectionItem { logicalKey: string } type instead of a string
  • Better aligning (fixing MUI bug)
  • Re-use components
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 3.38164% with 200 lines in your changes missing coverage. Please review.

Project coverage is 37.69%. Comparing base (7417864) to head (0a4e7d3).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...alog/app/containers/Bucket/Selection/Dashboard.tsx 0.00% 43 Missing ⚠️
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% 41 Missing ⚠️
...atalog/app/containers/Bucket/Selection/Control.tsx 0.00% 32 Missing ⚠️
...talog/app/containers/Bucket/Selection/Provider.tsx 0.00% 26 Missing ⚠️
catalog/app/containers/Bucket/Selection/utils.ts 0.00% 19 Missing ⚠️
...p/containers/Bucket/PackageDialog/S3FilePicker.tsx 0.00% 10 Missing ⚠️
catalog/app/containers/Bucket/Download.tsx 0.00% 9 Missing ⚠️
catalog/app/containers/Bucket/Listing.tsx 0.00% 8 Missing ⚠️
catalog/app/containers/Bucket/Dir.tsx 0.00% 4 Missing ⚠️
catalog/app/containers/Bucket/Meta.tsx 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4173      +/-   ##
==========================================
- Coverage   37.80%   37.69%   -0.12%     
==========================================
  Files         766      768       +2     
  Lines       35195    35317     +122     
  Branches     5190     5022     -168     
==========================================
+ Hits        13307    13313       +6     
- Misses      21280    21396     +116     
  Partials      608      608              
Flag Coverage Δ
api-python 91.09% <ø> (ø)
catalog 12.08% <3.38%> (-0.04%) ⬇️
lambda 87.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus changed the title Selective package download Select files and directories in a package to download Oct 11, 2024
@fiskus fiskus marked this pull request as ready for review October 11, 2024 15:27
@fiskus fiskus requested a review from nl0 October 11, 2024 15:45
nl0
nl0 previously approved these changes Oct 14, 2024
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

catalog/app/containers/Bucket/Meta.tsx Show resolved Hide resolved
catalog/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alexei Mochalov <[email protected]>
@fiskus
Copy link
Member Author

fiskus commented Oct 16, 2024

Used React.Provider for passing selection data instead of props. It was required to use utils/Dialog, because it is initialized in callback and doesn't react to props changes.

Also, fixed route guarding: confirming navigation from package page when something is selected. The condition turned out to be quite sprawling: https://github.com/quiltdata/quilt/pull/4173/files#diff-95c902495a06ff31c5e3a2bede51af727048f9151bede5b5195a4f2cb8fc5090R106

@fiskus fiskus requested a review from nl0 October 16, 2024 11:30
@fiskus fiskus added this pull request to the merge queue Oct 17, 2024
Merged via the queue into master with commit fd98908 Oct 17, 2024
37 of 39 checks passed
@fiskus fiskus deleted the selective-package-download branch October 17, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants