Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qurator dev tools #4192

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Qurator dev tools #4192

wants to merge 8 commits into from

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Oct 16, 2024

Description

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Confirm that this change meets security best practices and does not violate the security model
  • Documentation
    • run optipng on any new PNGs
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 37.77%. Comparing base (7417864) to head (02be249).

Files with missing lines Patch % Lines
catalog/app/components/Assistant/UI/Chat/Chat.tsx 0.00% 21 Missing ⚠️
...alog/app/components/Assistant/UI/Chat/DevTools.tsx 0.00% 12 Missing ⚠️
catalog/app/components/JsonDisplay/JsonDisplay.tsx 0.00% 6 Missing ⚠️
...log/app/components/Assistant/Model/Conversation.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4192      +/-   ##
==========================================
- Coverage   37.80%   37.77%   -0.04%     
==========================================
  Files         766      767       +1     
  Lines       35195    35230      +35     
  Branches     5190     5195       +5     
==========================================
  Hits        13307    13307              
- Misses      21280    21315      +35     
  Partials      608      608              
Flag Coverage Δ
api-python 91.09% <ø> (ø)
catalog 12.10% <0.00%> (-0.02%) ⬇️
lambda 87.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant