Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using S3 Select in indexer #4212

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Nov 8, 2024

Description

TODO

  • revert CI
  • Unit tests
  • Confirm that this change meets security best practices and does not violate the security model
  • Documentation
    • run optipng on any new PNGs
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 34.95%. Comparing base (7972243) to head (c007428).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
lambdas/indexer/index.py 0.00% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4212      +/-   ##
==========================================
- Coverage   37.69%   34.95%   -2.74%     
==========================================
  Files         768      768              
  Lines       35317    35337      +20     
  Branches     5215     5214       -1     
==========================================
- Hits        13313    12353     -960     
- Misses      20769    21750     +981     
+ Partials     1235     1234       -1     
Flag Coverage Δ
api-python 91.09% <ø> (ø)
catalog 12.07% <ø> (-0.01%) ⬇️
lambda 67.21% <0.00%> (-20.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant