Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error catching of injected user scripts #754

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

ACTCD
Copy link
Collaborator

@ACTCD ACTCD commented Nov 15, 2024

  • Fix async error not caught introduced by feat: supports top-level await and namespace isolation #750

  • Fix errors may not show up in console when injecting page context

    • For example, the page script prevented the default event:
      window.addEventListener('unhandledrejection', (event) => {
          event.stopImmediatePropagation();
          event.preventDefault();
      });
  • Fix the sourceURL resource not show up when the script name contains quotation marks

@ACTCD ACTCD requested a review from quoid November 15, 2024 23:16
@ACTCD ACTCD merged commit ddead3d into main Nov 16, 2024
1 check passed
@ACTCD ACTCD deleted the inject-js-try-catch-improves branch November 16, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants