Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pyright test #146

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Add Pyright test #146

merged 3 commits into from
Jul 19, 2024

Conversation

dkang-quora
Copy link
Contributor

No description provided.

@JelleZijlstra
Copy link
Collaborator

I started looking into running pyright on the main codebase but there are a ton of errors (over 100), so I diddn't pursue it. Good call to run it on just some smaller examples.

@dkang-quora
Copy link
Contributor Author

Yeah let's focus on correct typings in decorators.pyi.

@dkang-quora dkang-quora marked this pull request as ready for review July 18, 2024 23:57
@JelleZijlstra JelleZijlstra merged commit f3b82ca into quora:master Jul 19, 2024
8 of 9 checks passed
@dkang-quora dkang-quora deleted the pyright-test branch July 19, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants