Switch to domain named prop and fix tensorflow toString issue #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanocallaghan
force-pushed
the
tf-and-online-prop
branch
from
3355caa
to
26bb25e
Compare
|
As far as I can see, I'll update the version accordingly in another PR (and I don't see a reason to stick with Java 17 compatibility, so will also move that to 21). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the PR linked in #18, this uses the domain named property, which is a bit less ambiguous.
Also fixes an error when trying to call toString on a TensorFlow engine, it'd end up going into
LibUtils.getLibName()which leads eventually intodownloadTensorFlow, which fails given the default offline settingSee https://github.com/deepjavalibrary/djl/blob/1d3613aaab1fcc5cbb3398a60152f6ce49a76342/engines/tensorflow/tensorflow-engine/src/main/java/ai/djl/tensorflow/engine/TfEngine.java#L177C62-L177C72