Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: db: oracle workflow #721

Merged
merged 3 commits into from
Jan 12, 2024
Merged

ci: db: oracle workflow #721

merged 3 commits into from
Jan 12, 2024

Conversation

detule
Copy link
Collaborator

@detule detule commented Jan 11, 2024

Hi -

This establishes an oracle pipeline.

  • Unable to run the DBItest suite at this time - see Oracle support DBItest#348
    • Despite this, I think it is useful - provides an environment to test any custom oracle logic, and over time we can also write tests that test more generic functionality. I am hopeful we can also figure out how to run DBItest against this backend.
  • Currently workflow fails - needs oracle: tables: do not escape when using exact query #712 to pass.
────────────────────────────────────────────────────────────────────────────────
Failure ('test-driver-oracle.R:24:5'): Oracle
dbExistsTable(con, "mtcars_test") is not TRUE

`actual`:   FALSE
`expected`: TRUE 
Backtrace:
    ▆
 1. └─base::eval(...)
 2.   └─base::eval(...)
 3.     └─testthat::expect_true(dbExistsTable(con, "mtcars_test")) at test-driver-oracle.R:24:5

Error ('test-driver-oracle.R:26:7'): Oracle
<odbc::odbc_error/C++Error/error/condition>

Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to sequence the merges however you want; given that the builds are already failing, I think it's fine to merge this first.

I'll try and find some time today to do a patch for the DBI issues.

.github/odbc/odbcinst.ini Outdated Show resolved Hide resolved
tests/testthat/test-driver-oracle.R Outdated Show resolved Hide resolved
tests/testthat/test-driver-oracle.R Outdated Show resolved Hide resolved
@hadley hadley merged commit 257f041 into r-dbi:main Jan 12, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants