Added Arch Linux builders. #41
Conversation
arch/Dockerfile
Outdated
| # curl -o /usr/bin/pandoc-citeproc.gz \ | ||
| # https://files.r-hub.io/pandoc/linux-64/pandoc-citeproc.gz && \ | ||
| # gzip -d /usr/bin/pandoc-citeproc.gz && \ | ||
| # chmod +x /usr/bin/pandoc /usr/bin/pandoc-citeproc |
There was a problem hiding this comment.
What pandoc version does arch come with? Maybe it is better to use these static ones?
There was a problem hiding this comment.
Arch packages tend to be updated pretty quickly so they are often at/close to the most recent stable versions, in this case, pandoc 2.7.2 and pandoc-citeproc 0.16.1.3.
There was a problem hiding this comment.
Yeah, that's the thing, all other images have pandoc 1.x.x by default, and that's also what cran has. So maybe we should have 1.x.x here as well, and we can also have 2.x installed via sysreqs, if requested. This is to be worked out for the other images.
There was a problem hiding this comment.
Fair enough. I swapped out the pandoc versions. The command to installer the newer version of pandoc is still there in a comment just in case.
jenkins.sh
Outdated
| @@ -13,6 +13,10 @@ docker ps -a | grep 'Exited' | awk ' { print $1; } ' | xargs docker rm || true | |||
| # done manually, as needed. | |||
|
|
|||
| failed=0 | |||
| ./build-image.sh arch || failed=1 | |||
| ./build-image.sh arch-gcc || failed=1 | |||
| ./build-image.sh arch-clang || failed=1 | |||
There was a problem hiding this comment.
These images seem to be missing?
There was a problem hiding this comment.
I'm not a member of rhub, so I don't believe I will be able to push the images. If you want to add me, I'd be happy to do it. Otherwise I think you will likely need to push the images.
There was a problem hiding this comment.
If you want, I can also remove the jenkins.sh entries for now and we can add them back once the images have been pushed. Just let me know..
There was a problem hiding this comment.
What I am asking is that you seem to envision three images: rhub/arch, rhub/arch-gcc and arch-clang? No? Where are the Dockerfiles for those? The arch image does not have R installed.
There was a problem hiding this comment.
Ah apologies; I forgot to include them in the commit. I'll fix that now. Also, I'm not entirely sure that three images are necessary, but rather I'm just following the convention used for the Debian / Fedora images, with the assumption that some people will prefer one or the other.
There was a problem hiding this comment.
Thanks! I am still missing something. Seems like your arch image already has R. What are the arch-gcc and arch-clang images for, then?
Note that for e.g. Debian we have sg. like
debian: base image of all R-hub Debian imagesdebian-gcc: add GCCdebign-gcc-devel: add R-devel
But seems like you just want a single image with R installed from the default Arch Linux source? Which is completely fine, but then we do not need the arch-clang and arch-gcc images. R will use the same compiler as the one that was used to compile it, anyway. So it is enough to make that available on the image.
There was a problem hiding this comment.
Ah got it. I started with a single image, but then thought I would mirror the setup for Fedora/Debian, in case it was needed for some purpose. I'll revert to a single image in that case.
|
OK. Another thing you need to do is setting the sysreqs platform, like this: |
|
Ah. Thanks for pointing that out. I updated the Dockerfile accordingly. Just let me know if there is anything else I have forgotten. |
|
OK. Let me merge the sysreqs first.... |
|
OK, tested it a bit, some more testing and I'll add it to the official list.... |
I created the docker images (modeled after the fedora Dockerfiles) and tested them and they all appear to build fine. Just let me know if anything appears to be missing.