show_news(): Support NEWS in Rd and md formats and under inst #2551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2499.
Exactly mirrors the search path documented in utils::news() for NEWS files rather than using the regex approach proposed in the issue.
The existing code could only handle plain NEWS files. In order to support the alternative formats, I had to mirror what
utils::news
was doing via internaltools
machinery intools:::.build_news_db()
.I added some tests partly to convince myself it was working. Perhaps you don't want to take all of these though since it's effectively exercising the internal functions in
tools
more thandevtools
per se.