Implement resp_url() helpers #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgirlich
reviewed
Aug 17, 2023
mgirlich
reviewed
Aug 17, 2023
tests/testthat/test-resp-url.R
Outdated
|
|
||
| expect_equal(resp_url(resp), paste0(example_url(), "get?a=1&b=2")) | ||
| expect_equal(resp_url_path(resp), "/get") | ||
| expect_equal(resp_url_query(resp), list(a = "1", b = "2")) |
There was a problem hiding this comment.
Probably not really worth the complexity but this examples makes me wonder whether something like a ptypes argument would make sense. It would be nice to easily get list(a = 1, b = 2).
mgirlich
approved these changes
Aug 17, 2023
|
I think it would be nice to have |
Co-authored-by: Maximilian Girlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
Not sure if the query interface should look more like
resp_header()/resp_headers(), i.e. is it useful to provide a helper to extract a single query parameter and provide a default if it's not found?