Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAuth vignette & cache path customisation #286

Merged
merged 6 commits into from
Aug 31, 2023
Merged

Add OAuth vignette & cache path customisation #286

merged 6 commits into from
Aug 31, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Aug 26, 2023

Fixes #234

R/oauth.R Outdated
#'
#' @export
#' @keywords internal
cache_path <- function() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cache_path() is too generic and other packages or custom script already use that name. So maybe rather httr2_cache_path()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that cache_path() seems a bit too short, but no other function has an httr2_ prefix. Maybe oauth_cache_path() is a better name.

@hadley hadley merged commit 5247512 into main Aug 31, 2023
12 checks passed
@hadley hadley deleted the oauth-vignette branch August 31, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve docs for token caching
2 participants