Allow req_perform_stream() to perform non-blocking reads
#520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behaviour stays the same, but you can now specify `wait_for` in order to switch to a non-blocking request and call the callback as the data arrives. Fixes #519
jcheng5
reviewed
Aug 27, 2024
| line = function(bytes) which(bytes == charToRaw("\n")), | ||
| sse = function(bytes) { | ||
| is_newline <- which(bytes == charToRaw("\n")) | ||
| intersect(is_newline, is_newline + 1) |
|
Have you tried this with a real SSE server and do you end up with an extra callback with "\n" at the end? If "yes" and "no", LGTM! |
jcheng5
approved these changes
Aug 27, 2024
hadley
commented
Aug 27, 2024
| req_url_query(chunk_size = 1024) %>% | ||
| req_perform_stream(accumulate_bytes, wait_for = 0) | ||
| expect_equal(sum(bytes), 102400) | ||
| # I'm not sure why this is so much smaller than 100, but I suspect it |
There was a problem hiding this comment.
@jcheng5 does this explanation make sense to you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour stays the same, but you can now specify
wait_forin order to switch to a non-blocking request and call the callback as the data arrives.Fixes #519
@jcheng5 Does that feel like the right argument name? I have kept the behaviour the same as previously, but maybe the default should be
wait_for = 0? Does thewait_forimplementation loop look ok to you?