Make skip_if_offline() more robust by checking multiple hosts #1890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r-project.org has been down all morning, which is causing my package tests to be skipped. This PR updates
skip_if_offline()
to check multiple hosts, and returnsTRUE
on the first connection. It's backwards compatible because it still works when provided a single domain tohost
. And it will be just as fast once r-project.org is restored.I added github.com since it's hard to get much done anyways when GitHub is down. And I added captive.apple.com because I learned from sindresorhus/is-online that this is how iOS determines internet connectivity, so it should have a very reliable uptime.
If you are open to this update, I'll add an entry to
NEWS.md