Allow mocking of any object

NEWS.md

@@ -1,5 +1,8 @@
 # testthat (development version)
 
+* `local_mocked_bindings()` can now mock any object, not just functions 
+  (#1896).
+
 * `skip_if_offline()` now uses `captive.apple.com` by default. This is the 
   host that Apple devices use to check that they're online so should be 
   a higher reliability host than `r-project.org` (@jdblischak, #1890).

R/mock2.R

@@ -93,7 +93,8 @@
 #' )
 #' ```
 #' @export
-#' @param ... Name-value pairs providing functions to mock.
+#' @param ... Name-value pairs providing new values (typically functions) to
+#'   temporarily replace the named bindings.
 #' @param code Code to execute with specified bindings.
 #' @param .env Environment that defines effect scope. For expert use only.
 #' @param .package The name of the package where mocked functions should be
@@ -195,14 +196,6 @@ check_bindings <- function(x, error_call = caller_env()) {
       call = error_call
     )
   }
-
-  is_fun <- map_lgl(x, is.function)
-  if (!any(is_fun)) {
-    cli::cli_abort(
-      "All elements of {.arg ...} must be functions.",
-      call = error_call
-    )
-  }
 }
 
 # For testing -------------------------------------------------------------
@@ -244,6 +237,8 @@ show_bindings <- function(name, env = caller_env()) {
   invisible()
 }
 
+test_mock_value <- 10
+
 env_desc <- function(env) {
   cat(obj_address(env), ": ", env_name(env), "\n", sep = "")
 }

tests/testthat/_snaps/mock2.md

@@ -5,11 +5,6 @@
     Condition
       Error in `local_mocked_bindings()`:
       ! All elements of `...` must be named.
-    Code
-      with_mocked_bindings(1 + 1, x = 2)
-    Condition
-      Error in `local_mocked_bindings()`:
-      ! All elements of `...` must be functions.
 
 # can't mock bindings that don't exist
 

tests/testthat/test-mock2.R

@@ -44,7 +44,6 @@ test_that("can make wrapper", {
 test_that("with_mocked_bindings() validates its inputs", {
   expect_snapshot(error = TRUE, {
     with_mocked_bindings(1 + 1, function() 2)
-    with_mocked_bindings(1 + 1, x = 2)
   })
 })
 
@@ -81,3 +80,8 @@ test_that("can mock base functions with in-package bindings", {
   local_mocked_bindings(interactive = function() TRUE)
   expect_equal(test_mock_base(), TRUE)
 })
+
+test_that("can mock values", {
+  local_mocked_bindings(test_mock_value = 100)
+  expect_equal(test_mock_value, 100)
+})