Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed praise messages #1974

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

proposed praise messages #1974

wants to merge 1 commit into from

Conversation

pachadotdev
Copy link

Changes Made:

  • Replaced:

    • "\U0001f4a3 Your tests are da bomb \U0001f4a3"
    • "\U0001f525 Your tests are lit \U0001f525"

    with:

    • "\U0001f3b8 Your tests rock \U0001f3b8"
    • "\U0001f44f Your tests get an ovation \U0001f44f"

Reason for Changes:

While the original phrases are idiomatic expressions that fun and engaging, the new messages aim to maintain a positive and enthusiastic tone while being more sensitive with potential readers. In my own case, I recently received a lot of hate for being a member of a specific community and I could only think about that when I read that my tests are "the bomb". I know you never wanted to communicate anything negative, and my change points at keeping the inclusiveness that characterizes the R community.

Respectfully,
Pacha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant