Skip to content

Commit

Permalink
Test less about the the GHA config files
Browse files Browse the repository at this point in the history
These tests started failing after some changes in r-lib/actions and it feels like we are testing too much about the content of the YAML here.
  • Loading branch information
jennybc committed Aug 5, 2024
1 parent 1047825 commit e195e1f
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions tests/testthat/test-github-actions.R
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,6 @@ test_that("use_github_action() accepts a name", {
expect_proj_dir(".github/workflows")
expect_proj_file(".github/workflows/R-CMD-check.yaml")

yml <- yaml::yaml.load_file(proj_path(".github/workflows/R-CMD-check.yaml"))
expect_identical(yml$name, "R-CMD-check")
expect_named(yml$jobs, "R-CMD-check")

readme_lines <- read_utf8(proj_path("README.md"))
expect_match(readme_lines, "R-CMD-check", all = FALSE)

Expand All @@ -129,9 +125,6 @@ test_that("use_tidy_github_actions() configures the full check and pr commands",
expect_proj_file(".github/workflows/R-CMD-check.yaml")

yml <- yaml::yaml.load_file(proj_path(".github/workflows/R-CMD-check.yaml"))
expect_identical(yml$name, "R-CMD-check")
expect_named(yml$jobs, "R-CMD-check")

size_build_matrix <-
length(yml[["jobs"]][["R-CMD-check"]][["strategy"]][["matrix"]][["config"]])
expect_gte(size_build_matrix, 6) # release, r-devel, 4 previous versions
Expand Down

0 comments on commit e195e1f

Please sign in to comment.