Speed up tests #1908
Merged
Speed up tests #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hadley
commented
Oct 31, 2023
hadley
commented
- Enable parallel testing. For me, this dropped runn time down from 30s to 11s, 10s of which is the release tests.
- Refactor release tests to avoid expensive CRAN downloads. This has equivalent test coverage but reduces test time from 10s to 4s, bringing total test time down to around 8 seconds.
- Start the slowest tests (github-actions and release) first. This brings total test time down to around 6s
* Enable parallel testing. For me, this dropped runn time down from 30s to 11s, 10s of which is the release tests. * Refactor release tests to avoid expensive CRAN downloads. This has equivalent test coverage but reduces test time from 10s to 4s, bringing total test time down to around 8 seconds. * Start the slowest tests (github-actions and release) first. This brings total test time down to around 6s
jennybc
approved these changes
Oct 31, 2023
| utils::available.packages(repos = default_cran_mirror()), | ||
| available.packages(repos = default_cran_mirror()), |
There was a problem hiding this comment.
Just mildly curious. Does this make a difference?
Updated: oh I see you want to mock it.
|
Abstractly I think the turns the tests around 90°; they still cover the same stuff but in a rather different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.