Add more PR links #1981
Closed
Add more PR links #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
commented
Apr 13, 2024
| @@ -967,22 +969,22 @@ pr_branch_delete <- function(pr) { | |||
|
|
|||
| if (is.null(pr_ref)) { | |||
| ui_bullets(c( | |||
| "i" = "PR {.val {pr$pr_string}} originated from branch {.val {pr_remref}}, | |||
| "i" = "{.href [PR {pr$pr_string}]({pr$pr_html_url})} originated from branch {.val {pr_remref}}, | |||
There was a problem hiding this comment.
Suggested change
| "i" = "{.href [PR {pr$pr_string}]({pr$pr_html_url})} originated from branch {.val {pr_remref}}, | |
| "i" = "{.href [PR {pr$pr_number}]({pr$pr_html_url})} originated from branch {.val {pr_remref}}, |
This looks a bit bad.
Any reason on why not just including the PR Number?
olivroy
commented
Apr 13, 2024
| ) | ||
| cli::format_inline(template) | ||
| } | ||
| } | ||
| ) | ||
| choice <- utils::menu(title = prompt, choices = cli::ansi_strtrim(dat_pretty)) | ||
| choice <- utils::menu(title = prompt, choices = cli::ansi_strtrim(dat_pretty, width = cli::console_width() - 1L)) |
There was a problem hiding this comment.
full width looks bad currently in RStudio (tends to switch line)
Saw the same thing in r-lib/styler#1189.
|
This is probably too verbose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on main:
this PR:
Just as
pr_resume()can be used as a sitrep. If cancelling, it would be possible to have a direct link topr_resume('branch').I also added more links to PRs in other pr functions (will test interactively in the coming days)