tweak compute_name() to recognize snapshot files
#1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Closed
|
In the name of getting this merged, will you narrow this down to just address #1988? I'd like to keep it separate from the messier matter of test helper files. |
olivroy
commented
Jun 27, 2024
olivroy
changed the title
compute_name() to recognize test helper and snapshot filescompute_name() to recognize snapshot files
hadley
reviewed
Jun 28, 2024
hadley
approved these changes
Jun 28, 2024
Co-authored-by: Hadley Wickham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1988
Tested manually that this worked as expected too!
I decided to create a PR because I had squeezed in and tested something similar in #1978 (comment) and I thought I'd separate out in another PR.