Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CXX17 the default #12

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Make CXX17 the default #12

merged 1 commit into from
Jan 15, 2024

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Jan 5, 2024

This matches config of R 4.3 on other platforms, for example on Linux:

# R CMD config CXX
g++ -std=gnu++17

# R CMD config CXXFLAGS
-g -O2

This fixes r-wasm/webr#347.

Ps: it is unclear to me how webr-vars.mk related to in this package related to the one in webr. Do we fix it there as well?

@jeroen jeroen force-pushed the main branch 2 times, most recently from 0f1aa61 to c74af52 Compare January 9, 2024 18:32
This matches config of R 4.3 on other platforms.
Fixes r-wasm/webr#347
Copy link
Member

@georgestagg georgestagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

it is unclear to me how webr-vars.mk related to in this package related to the one in webr. Do we fix it there as well?

That version is used for building the extra packages provided in the webr/packages directory as part of the webR build process. In principle, we should probably fix it there too, but at the moment the only extra package included is the webr support package, which does not use any C++ code anyway.

@georgestagg georgestagg merged commit e990aa1 into r-wasm:main Jan 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CXX should default to C++17
2 participants