WIP: Danger.systems Integration

.editorconfig

@@ -16,6 +16,9 @@ ij_kotlin_imports_layout = *
 ij_kotlin_allow_trailing_comma = true
 ij_kotlin_allow_trailing_comma_on_call_site = true
 
+[*.df.kts]
+ktlint_standard_no-wildcard-imports = disabled
+
 [*.sq]
 indent_size = 2
 ij_continuation_indent_size = 2

.github/workflows/build.yml

@@ -9,7 +9,20 @@ on:
   pull_request:
 
 jobs:
+  danger:
+    runs-on: ubuntu-latest
+    name: "danger"
+    steps:
+      - uses: actions/checkout@v1
+      - name: Danger
+        uses: docker://ghcr.io/danger/danger-kotlin:1.2.0
+        with:
+          args: --failOnErrors --no-publish-check
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
   code-style:
+    needs: [danger]
     runs-on: macos-latest
     timeout-minutes: 60
 #    env:

.gitignore

@@ -91,3 +91,6 @@ report.xml
 Preview.html
 screenshots/**/*.png
 test_output
+/.idea/appInsightsSettings.xml
+/iosApp/iosApp.xcodeproj/project.xcworkspace/contents.xcworkspacedata
+/iosApp/iosApp.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist

Dangerfile.df.kts

@@ -0,0 +1,33 @@
+import systems.danger.kotlin.*
+
+danger(args) {
+
+  val allSourceFiles = git.modifiedFiles + git.createdFiles
+  val changelogChanged = allSourceFiles.contains("CHANGELOG.md")
+  val sourceChanges = allSourceFiles.firstOrNull { it.contains("src") }
+
+  onGitHub {
+    val isTrivial = pullRequest.title.contains("#trivial")
+
+    message("This PR has been checked by Danger")
+
+    // Changelog
+    if (!isTrivial && !changelogChanged && sourceChanges != null) {
+      warn(
+        "any changes to library code should be reflected in the Changelog.\n\n" +
+          "Please consider adding a note there and adhere to the " +
+          "[Changelog Guidelines](https://github.com/Moya/contributors/blob/master/Changelog%20Guidelines.md).",
+      )
+    }
+
+    // Big PR Check
+    if ((pullRequest.additions ?: 0) - (pullRequest.deletions ?: 0) > 300) {
+      warn("Big PR, try to keep changes smaller if you can")
+    }
+
+    // Work in progress check
+    if (pullRequest.title.contains("WIP", false)) {
+      warn("PR is classed as Work in Progress")
+    }
+  }
+}

build.gradle.kts

@@ -24,14 +24,7 @@ allprojects {
   tasks.withType<KotlinCompilationTask<*>>().configureEach {
     compilerOptions {
       // Treat all Kotlin warnings as errors
-//      allWarningsAsErrors.set(true)
-
-      // Hack to make klib manifests have an actually unique name
-//      val uniqueName = "${[email protected]}.${[email protected]}"
-//      freeCompilerArgs.addAll(
-//        "-module-name",
-//        uniqueName,
-//      )
+      allWarningsAsErrors.set(true)
 
       if (project.hasProperty("deckbox.enableComposeCompilerReports")) {
         freeCompilerArgs.addAll(
@@ -47,16 +40,10 @@ allprojects {
       }
     }
   }
+}
 
-//  pluginManager.withPlugin("kotlin-multiplatform") {
-//    val kotlinExtension = project.extensions.getByName("kotlin")
-//      as org.jetbrains.kotlin.gradle.dsl.KotlinMultiplatformExtension
-//    val uniqueName = "${project.group}.${project.name}"
-//
-//    kotlinExtension.targets.withType(org.jetbrains.kotlin.gradle.plugin.mpp.KotlinNativeTarget::class.java) {
-//      compilations.configureEach {
-//        kotlinOptions.freeCompilerArgs += listOf("-module-name", uniqueName)
-//      }
-//    }
-//  }
+tasks.register<Copy>("bootstrap") {
+  from(file("scripts/pre-push"))
+  into(file(".git/hooks"))
+  fileMode = 777
 }

scripts/pre-push

@@ -0,0 +1,16 @@
+#!/bin/sh
+
+echo "**** Running Pre-Push Check ****"
+
+git stash -q --keep-index
+
+./gradlew spotlessCheck
+./gradlew -P gradle/build-logic spotlessCheck
+
+status=$?
+
+git stash pop -q
+
+echo "**** Pre-Push Check Finished ****"
+
+exit $status